[1.18.2] U.S. English translation revamp, backport, and cleanup of other lang files #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a backport of PR #3780 and PR #3799, as well as the recently accepted and merged Japanese and Polish translations, which unfortunately didn't make it into that cleanup. For a detailed list of changes, please refer to the linked pull requests.
Of course, due to the differences (sometimes significant) between JEI for 1.21.1 and 1.18.2, not everything could be backported, and even if it could, it didn't always make sense. For example, almost every time I switched to an older version, there were some differences in the configuration options offered by JEI. So, for obvious reasons, there was no point in backporting descriptions for options that simply don't exist in that older version.
In addition, there's also something new here — the removal of all remnants of the old in-game configuration interface from translation files. This interface hasn't been in use for years, the configuration option descriptions are outdated, and some of them don't even correspond to any available options in config files anymore, while others are just missing. If the in-game configuration interface were to be reintroduced in JEI for this Minecraft version, it would probably make more sense to backport everything from 1.21.1 instead.